Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE parameters-check.md 实例元数据注释 #763

Merged

Conversation

fuhouyu
Copy link
Contributor

@fuhouyu fuhouyu commented Aug 9, 2024

What is the purpose of the change

resolves alibaba/nacos#12466
对该issue在parameters-check.md 添加注释。

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Test your code locally by running npm run build, and make sure it works as expected.
  • Make sure no files under build directory is added.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2024

CLA assistant check
All committers have signed the CLA.

@@ -27,14 +27,14 @@ sidebar:
|参数描述|最大字符长度|校验规则|
|-----|-----|-----|
|命名空间名称|256|禁止`@#$%^&*`,对应正则表达式:`[^@#$%^&*]+$`|
|命名空间ID|64|只允许字母数字下划线以及"-"字符,对应正则表达式:`^[\w-]+`|
|命名空间ID|64|只允许字母数字下划线以及"-"字符,对应正则表达式:`^[\w-]+`||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行是多了个|吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实是的。老师,我改下。……

@KomachiSion KomachiSion merged commit 10c2966 into nacos-group:develop-astro-nacos Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos对于Service Metadata大小的限制问题
3 participants